Keyboard shortcuts in the diff viewer don't always work
The issue refers to the diff viewer window. The CTRL + + and CTRL + - keyboard shortcuts are handled globally within the window, no matter where keyboard focus is. On the other hand, the CTRL + M and CTRL + N (and their counterparts with Shift pressed) work only when keyboard focus is in the diff pane on the bottom.
The problem is that when you want to go through a code review, you have to click the diff pane whenever you switch to another file. Please check it by yourself: open the diff viewer, press CTRL + + and then try to use any of the other shourtcuts to move through the changes. They won't work. It makes code reviews painful.
I will be grateful if you fix it. Thank you!
There actually was an existing topic for the issue, but it was declined because of a misunderstanding, I guess (https://plasticscm.uservoice.com/forums/15467-general/suggestions/10643718-forward-prev-next-diff-keys-to-inline-diff-from-pa). The topic was wrongly considered to be a duplicate, but the thing is, the issue in question was related to something else.
Mariusz Schimke
shared this idea
-
Göran Wallgren
commented
The quickest fix for this ticket is to simply activate (in Pending Changes) the same Ctrl++ and Ctrl+- shortcut keys that are currently working (since 5.4.14.707 or .806) in the other Diff Changeset views but NOT in Pending Changes!
-
Göran Wallgren
commented
WAIT!!! This is not fully fixed in .806! It still won't work in Pending Changes, only in Diff Changeset etc. PLEASE fix Pending Changes as well, since that is one of the most important places to have this!
-
Göran Wallgren
commented
Fixes for this were included in 5.4.16.806. Thanks!