Göran Wallgren

My feedback

  1. 6 votes
    Vote
    Sign in
    Check!
    (thinking…)
    Reset
    or sign in with
    • facebook
    • google
      Password icon
      Signed in as (Sign out)
      You have left! (?) (thinking…)
      0 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
      Göran Wallgren shared this idea  · 
    • 44 votes
      Vote
      Sign in
      Check!
      (thinking…)
      Reset
      or sign in with
      • facebook
      • google
        Password icon
        Signed in as (Sign out)
        You have left! (?) (thinking…)
        10 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
        Göran Wallgren commented  · 

        The use-case is that you need to trace a certain block of code back in time (from the current changeset, let's say 32000) to see why and how it was changed. This must be done on a per-line basis, so the previous changeset (let's say 31000) of the whole file is pretty useless. In Annotate you can view a line/block and see at what changeset (let's say 30000) it was changed to the current reading. Then you very often want to know how that line/block read just before that latest change. That's why we need to be able to annotate the previous changeset for a specific line (let's say 29000). Your new feature takes us from cs:32000 to 31000, but we really need a way to go from cs:32000 to 29000 (line-specific)...

        Göran Wallgren commented  · 

        The majority of suggestions here were addressed in 6.0.16.1471, thanks! However, the most important missing feature, "annotate previous changeset", was _not_ implemented the way it's suggested here and the way it works in TortoiseBlame!

        The implemented feature simply opens Annotate on the previous changeset where ANY LINE in the file was changed. But that is not what was requested. What we need, and what TortoiseBlame does, is to open Annotate on the previous changeset where the SELECTED LINE was changed.

        Göran Wallgren commented  · 

        * When there are local changes, it's not very useful to see these in the Annotate view. Instead we should see the latest Checked-in changes (at least optionally)...

        Göran Wallgren commented  · 

        Also, the line that was selected (when requesting the Annotate) should be pre-selected (and scrolled into view) when the Annotate view appears. This is related to the following uservoice:
        https://plasticscm.uservoice.com/forums/15467-general/suggestions/3533001-annotate-this-line

        Göran Wallgren supported this idea  · 
        Göran Wallgren commented  · 

        Yes, "Annotate previous changeset" is the most important of my suggestions here. It's a must-have feature for any Annotate/Blame implementation... Without it, you can only see the latest revision of a line or block of code, with no quick way to trace it further back into history.

        Göran Wallgren commented  · 

        OK, didn't see the info bar at the bottom... :P However, the bottom area works fine, except that it should be updated when I move the cursor to a line that comes from another changeset (at least when the cursor is in the left area)! That is, when clicking a changeset line in the left area it becomes selected, but it should also be possible to move the selection with cursor up/down and PgUp/PgDn keys.

        Göran Wallgren shared this idea  · 
      • 9 votes
        Vote
        Sign in
        Check!
        (thinking…)
        Reset
        or sign in with
        • facebook
        • google
          Password icon
          Signed in as (Sign out)
          You have left! (?) (thinking…)
          6 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
          Göran Wallgren commented  · 

          For reference, the "multi-screen diff" feature was "documented" in the following release notes:

          "Release 6.0.16.920 Mar 22 2017

          Windows GUI: dynamic diff window to help diffing code in multi-screen setups.

          You can show the diffs from a branch or changeset, move the window to a second screen, and the diffs will be updated when you select a different changeset or branch. This is super useful to review changes.

          The diff window will be updated if you select a different branch in Branch Explorer or the branches view, and same for changesets. It works for shelves too.

          You can skip this behavior launching the diff window using Shift + DoubleClick. When there are more than one "dynamic" diff, the diffs won't be updated."

          Göran Wallgren commented  · 

          That's right, this new "multi-monitor" setup in the 6.0 Beta is a nice improvement!

          Göran Wallgren commented  · 
          Göran Wallgren commented  · 

          I second this! Add a "Show/Hide Changes" toggle in the Changesets and Branch Explorer views. (Very similar to the "Show/Hide Diffs" in the Pending Changes and 2D History (Version tree, for a single file) views, but here you need also the list of changed items.

          Göran Wallgren supported this idea  · 
        • 9 votes
          Vote
          Sign in
          Check!
          (thinking…)
          Reset
          or sign in with
          • facebook
          • google
            Password icon
            Signed in as (Sign out)
            You have left! (?) (thinking…)
            0 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
            Göran Wallgren shared this idea  · 
          • 15 votes
            Vote
            Sign in
            Check!
            (thinking…)
            Reset
            or sign in with
            • facebook
            • google
              Password icon
              Signed in as (Sign out)
              You have left! (?) (thinking…)
              5 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
              Göran Wallgren commented  · 

              The most confusing part is that the per-machine tabs are not "sticky", so they dis-/appear when switching the active workspace...

              Göran Wallgren commented  · 

              A first step towards this was (perhaps) taken in Beta 6.0.16.1013:
              "Windows GUI: We improved the way to switch workspaces. Now instead of tabs there is a button with the last N recently used workspaces (7 by default). You can change this value by editing the "RecentWorkspacesCount" property in the guiclient.conf file, placed on ~/AppData/Local/plastic4 directory."

              So now the workspaces are gathered in a dropdown. Most of the buttons in the left sidebar will open a tab that is specific to the active workspace, but the following will not since they are instead of a per-machine or per-user nature (re-ordered) :

              - Sync repositories
              - Cloud
              - Repositories
              - Workspaces
              - Preferences
              - About
              - Blog news

              Göran Wallgren commented  · 

              This one was started over a year ago?

              Göran Wallgren supported this idea  · 
            • 10 votes
              Vote
              Sign in
              Check!
              (thinking…)
              Reset
              or sign in with
              • facebook
              • google
                Password icon
                Signed in as (Sign out)
                You have left! (?) (thinking…)
                2 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                Göran Wallgren supported this idea  · 
              • 6 votes
                Vote
                Sign in
                Check!
                (thinking…)
                Reset
                or sign in with
                • facebook
                • google
                  Password icon
                  Signed in as (Sign out)
                  You have left! (?) (thinking…)
                  3 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                  Göran Wallgren commented  · 

                  The quickest fix for this ticket is to simply activate (in Pending Changes) the same Ctrl++ and Ctrl+- shortcut keys that are currently working (since 5.4.14.707 or .806) in the other Diff Changeset views but NOT in Pending Changes!

                  Göran Wallgren commented  · 

                  WAIT!!! This is not fully fixed in .806! It still won't work in Pending Changes, only in Diff Changeset etc. PLEASE fix Pending Changes as well, since that is one of the most important places to have this!

                  Göran Wallgren supported this idea  · 
                  Göran Wallgren commented  · 

                  Fixes for this were included in 5.4.16.806. Thanks!

                • 96 votes
                  Vote
                  Sign in
                  Check!
                  (thinking…)
                  Reset
                  or sign in with
                  • facebook
                  • google
                    Password icon
                    Signed in as (Sign out)
                    You have left! (?) (thinking…)
                    8 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                    Göran Wallgren supported this idea  · 
                  • 9 votes
                    Vote
                    Sign in
                    Check!
                    (thinking…)
                    Reset
                    or sign in with
                    • facebook
                    • google
                      Password icon
                      Signed in as (Sign out)
                      You have left! (?) (thinking…)
                      1 comment  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                      Göran Wallgren supported this idea  · 
                    • 3 votes
                      Vote
                      Sign in
                      Check!
                      (thinking…)
                      Reset
                      or sign in with
                      • facebook
                      • google
                        Password icon
                        Signed in as (Sign out)
                        You have left! (?) (thinking…)
                        3 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                        Göran Wallgren commented  · 

                        My request is that I'd like to see at-a-glance:
                        (1) which changeset I'm currently at.
                        (2) which branch I'm currently switched to.

                        The GUI always shows (2) but not as readily (1), while the "cm status" CLI command always shows (1) and only shows (2) if requested via a special option.

                        Thus, you are not consistent in showing this info between your GUI and CLI... IMHO, both (1) and (2) should be shown by default in both GUI and CLI.

                        Göran Wallgren commented  · 

                        Additional note: It would also be very useful to see here the latest changeset number on the switched branch, if it differs from the one loaded!

                        BTW, to show this updated info we might have to press the Reload icon in the "selector bar". (Strangely enough, that icon is located at the far right while in all other views the Reload icon is located immediately to the left...)

                        Göran Wallgren shared this idea  · 
                      • 6 votes
                        Vote
                        Sign in
                        Check!
                        (thinking…)
                        Reset
                        or sign in with
                        • facebook
                        • google
                          Password icon
                          Signed in as (Sign out)
                          You have left! (?) (thinking…)
                          4 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                          Göran Wallgren commented  · 
                          Göran Wallgren commented  · 

                          Some of the colors are already customizable via text files, so a minimal implementation would be to simply expose the rest of those colors to the user.

                          Göran Wallgren supported this idea  · 
                        • 29 votes
                          Vote
                          Sign in
                          Check!
                          (thinking…)
                          Reset
                          or sign in with
                          • facebook
                          • google
                            Password icon
                            Signed in as (Sign out)
                            You have left! (?) (thinking…)
                            3 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                            Göran Wallgren commented  · 

                            Branches can already be custom-colored via "Conditional format", based on attributes.

                            Since attributes can also be applied to labels, all that's needed (for consistency) is to extend the "conditional format" coloring feature to Labels as well!

                            Göran Wallgren supported this idea  · 
                          • 7 votes
                            Vote
                            Sign in
                            Check!
                            (thinking…)
                            Reset
                            or sign in with
                            • facebook
                            • google
                              Password icon
                              Signed in as (Sign out)
                              You have left! (?) (thinking…)
                              2 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                              Göran Wallgren commented  · 

                              In short: When zooming out, stop shrinking the font before it becomes unreadable.

                              Göran Wallgren supported this idea  · 
                            • 11 votes
                              Vote
                              Sign in
                              Check!
                              (thinking…)
                              Reset
                              or sign in with
                              • facebook
                              • google
                                Password icon
                                Signed in as (Sign out)
                                You have left! (?) (thinking…)
                                5 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                Göran Wallgren commented  · 

                                The most basic improvement to the Branch Explorer layout would be to simply replicate the same "vertical ordering" that you get in the Branches view when you enable "Tree view" (instead of "List view") !

                                Göran Wallgren commented  · 

                                I added one more screenshot "crossing_lines.png" to the dropbox URL mentioned earlier.

                                The new screenshot shows a smaller and simpler case where you can see a couple of grand-child-branches that are not sorted according to their hierarchical parent-child relationship. Instead the lines indicating ancestry (the "cross-branch changeset links") are allowed to cross other (cousin or unrelated) branches.

                                What I'd like to see is a more strictly hierarchical default layout.

                                Göran Wallgren commented  · 
                                Göran Wallgren commented  · 

                                Here you can view two screenshots, one is the default Branch Explorer layout and in the other one I have manually done "relayout" to match the "branch namespace" hierarchy. I think the "sorted" one is much easier to grasp, since there is much less line-crossing and (grand-)child branches follow logically beneath their parents.

                                This hierarchical sorting is something that could easily be done automatically (by default).

                                Göran Wallgren shared this idea  · 
                              • 9 votes
                                Vote
                                Sign in
                                Check!
                                (thinking…)
                                Reset
                                or sign in with
                                • facebook
                                • google
                                  Password icon
                                  Signed in as (Sign out)
                                  You have left! (?) (thinking…)
                                  4 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                  Göran Wallgren commented  · 

                                  This is slightly related to this other uservoice: https://plasticscm.uservoice.com/forums/15467-general/suggestions/9655032-improve-vertical-ordering-in-branch-explorer-make

                                  I find the default visual layout to be rather random. Being able to use a branch-weight attribute for auto-layout would definitely help in improving this.

                                  (However, as requested in the above uservoice, I would also want the option to order branches vertically by namespace/parentage.)

                                  Göran Wallgren supported this idea  · 
                                • 8 votes
                                  Vote
                                  Sign in
                                  Check!
                                  (thinking…)
                                  Reset
                                  or sign in with
                                  • facebook
                                  • google
                                    Password icon
                                    Signed in as (Sign out)
                                    You have left! (?) (thinking…)
                                    3 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                    Göran Wallgren commented  · 

                                    To keep these uservoices separated: This one is only about colors, while the other one is about adding additional visual indicators for selections.

                                    Göran Wallgren shared this idea  · 
                                  • 6 votes
                                    Vote
                                    Sign in
                                    Check!
                                    (thinking…)
                                    Reset
                                    or sign in with
                                    • facebook
                                    • google
                                      Password icon
                                      Signed in as (Sign out)
                                      You have left! (?) (thinking…)
                                      2 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                      Göran Wallgren commented  · 

                                      Related improvements were included in the Labs/Beta release 6.0.16.920, Mar 22, 2017:

                                      "Windows GUI: dynamic diff window to help diffing code in multi-screen setups.

                                      You can show the diffs from a branch or changeset, move the window to a second screen, and the diffs will be updated when you select a different changeset or branch. This is super useful to review changes.

                                      The diff window will be updated if you select a different branch in Branch Explorer or the branches view, and same for changesets. It works for shelves too.

                                      You can skip this behavior launching the diff window using Shift + DoubleClick. When there are more than one "dynamic" diff, the diffs won't be updated."

                                    • 2 votes
                                      Vote
                                      Sign in
                                      Check!
                                      (thinking…)
                                      Reset
                                      or sign in with
                                      • facebook
                                      • google
                                        Password icon
                                        Signed in as (Sign out)
                                        You have left! (?) (thinking…)
                                        1 comment  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                        Göran Wallgren supported this idea  · 
                                      • 4 votes
                                        Vote
                                        Sign in
                                        Check!
                                        (thinking…)
                                        Reset
                                        or sign in with
                                        • facebook
                                        • google
                                          Password icon
                                          Signed in as (Sign out)
                                          You have left! (?) (thinking…)
                                          2 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                          Göran Wallgren supported this idea  · 
                                        • 6 votes
                                          Vote
                                          Sign in
                                          Check!
                                          (thinking…)
                                          Reset
                                          or sign in with
                                          • facebook
                                          • google
                                            Password icon
                                            Signed in as (Sign out)
                                            You have left! (?) (thinking…)
                                            0 comments  ·  General  ·  Flag idea as inappropriate…  ·  Admin →
                                            Göran Wallgren supported this idea  · 
                                          ← Previous 1 3 4 5 6 7

                                          Feedback and Knowledge Base