I suggest you ...

Reply in Code Review

Sort comments in a Code review according to files and lines to which they are connected to and then according to a timestamp of a last edit instead of sorting it according to a timestamp of a last edit only.
Ideally indent comments to the same line and add a Reply button too.

141 votes
Vote
Sign in
Check!
(thinking…)
Reset
or sign in with
  • facebook
  • google
    Password icon
    I agree to the terms of service
    Signed in as (Sign out)
    You have left! (?) (thinking…)
    JakubHJakubH shared this idea  ·   ·  Flag idea as inappropriate…  ·  Admin →

    3 comments

    Sign in
    Check!
    (thinking…)
    Reset
    or sign in with
    • facebook
    • google
      Password icon
      I agree to the terms of service
      Signed in as (Sign out)
      Submitting...
      • Sergio NavarroSergio Navarro commented  ·   ·  Flag as inappropriate

        Initially I agreed with this "Add a new comment for the same line is bad, because your comment will be added to the end of the comment list – so the reply is far from the comment it react too" but after check that when you double click on the commented line you see all the comments related with that line I don't think it is so bad to follow a conversation.
        What I think still is needed to have a fluent conversation during the review process is the possibility of filtering comments to see quickly only new comments. I mean that you can choose from which date you want to see comments in the comments list. The dates to filter could be shown in a combo where you can select, no filter or one of the dates in which the revision changed its state or its assignee user. What it is important is that by default the list is filtered by last date when the revision changed its state or its assignee user.
        In that way you can see very quickly what commented you other user on his last revision

      • JakubHJakubH commented  ·   ·  Flag as inappropriate

        Adding the possibility to sort review comments by files and lines (and then by timestamp) at least seems to be pretty simple for so many votes, isn't it? Or is there any other issue with that?

      • JakubHJakubH commented  ·   ·  Flag as inappropriate

        http://www.plasticscm.net/index.php?/topic/1291-some-ux-issues/?p=12646
        Replying to a comment in the Code Review tool is very cumbersome. There are two options: add a new comment for the same line or edit the comment you want to react to. The first option is bad, because your comment will be added to the end of the comment list – so the reply is far from the comment it react too. The second option is bad too, because you are editing a comment by someone else and you need to add your name manually to identify yourself.

        The solution seems to be quite easy – order comments according to files and lines to which they are connected to and then according to a timestamp of a last edit instead of sorting it according to a timestamp of a last edit only.

        A button such as Reply to this comment for easy reacting would be nice too. Maybe you can indent comments to the same line of code too.

      Feedback and Knowledge Base