Bug: Edit changes in Visual Studio Plugin loses changes
After editing a checkedout file in Visual Studio, open "Diff with previous". The changes can be edited. I found the "Save" button on top (hard to see...), but if you close the window before saving all changes are lost with no warning. I think that is a serious bug.
Done! Available in the 695 release.
This is still not working properly.
Example: File has local modification, one line of text was added.
- Open diff by context menu "Diff with previous..."
- Don't click in one of the two edit panes!
- Remove the added code by pressing the 'x' button left of the code lines.
- File is marked as changed (red in the header bar), info "Files are identical".
- Press CTRL+S -> wait cursor appears for a short time
- Press CTRL+F4 to close the diff
-> File is closed, no warning, but changed content is not saved.
It does work if you click in the edit pane before pressing CTRL+S.
Thank you, Pablo!
Ok, we won't disable it then :-)
We'll try to add your suggestion asap. :-)
Probably it will take a week or so, because we have a bunch of other stuff to do first, but we'll do it asap.
> Oh god! I didn't say that.
So it was a misunderstanding, I'm very sorry!
> ... we'll disable the edit option on visual studio in the next release...
Please don't! It's a very important functionality for my daily workflow and for many in my team. We just need to remember to save in all cases, I guess we can handle that.
Oh god! I didn't say that.
I say that while it is nice to have, please consider there are workarounds to it.
Anyway, we'll disable the edit option on visual studio in the next release, so the behavior is consistent.
Your reply in other words: "It's no bug if a customer loses his work done in his rare time." Ok, your opinion. Just let me say that any software I know warns users before throwing away their work.
Yep, it is a nice suggestion but again, we don't consider it a bug.
Why it is not in the VS plugin? Easy: because we didn't consider it a high prio. We have limited time and limited resources, like any dev team, so we need to prioritize.
We would love to have unlimited time to be able to solve all possible small glitches like this one, but we unfortunately don't.
So we need our users to take this into account when submitting issues, because we definitely don't have time for everything.
I don't want it to save automatically but to show a dialog that warns that there are unsaved changes. There is this kind of dialog when editing in the Plastic SCM software, so why not in the VS plugin?
I very often edit in the diff viewer, e.g. to revert single lines of changed code but keep the rest.
Well, if you don't save, why should it save?? I mean, I don't think anyone will be doing lots of work on a diff window, will they? Or closing the window without saving! :-O